Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rfc6455Connector compatible with PHP 8.4 #53

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

foxycode
Copy link
Contributor

Fixes this error:

Deprecated: Amp\Websocket\Client\Rfc6455Connector::__construct():
    Implicitly marking parameter $httpClient as nullable is deprecated,
    the explicit nullable type must be used instead in src/Rfc6455Connector.php on line 32

Fixes this error:

```
Deprecated: Amp\Websocket\Client\Rfc6455Connector::__construct():
    Implicitly marking parameter $httpClient as nullable is deprecated,
    the explicit nullable type must be used instead in src/Rfc6455Connector.php on line 32
```
@kelunik kelunik merged commit faa92ba into amphp:2.x Nov 26, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants